Feat[MQB]: add authentication with basic logic #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbeard
reviewed
Apr 9, 2025
src/groups/bmq/bmqp/bmqp_ctrlmsg.xsd
Outdated
Comment on lines
1612
to
1613
| <element name='authenticateRequest' type='tns:AuthenticateRequest'/> | ||
| <element name='authenticateResponse' type='tns:AuthenticateResponse'/> |
There was a problem hiding this comment.
From our discussion today, we're leaning toward moving these types to a new, top-level complexType that just contains the authentication protocols.
emelialei88
force-pushed
the
feat/authn-protocol
branch
4 times, most recently
from
d923a9d to
6737422
Compare
Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
Signed-off-by: Emelia Lei <[email protected]>
emelialei88
force-pushed
the
feat/authn-protocol
branch
from
6737422 to
fe5f4fb
Compare
…ation Signed-off-by: Emelia Lei <[email protected]>
emelialei88
force-pushed
the
feat/authn-protocol
branch
from
fe5f4fb to
515517d
Compare
emelialei88
changed the title
emelialei88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broker side:
AuthenticationEventevent type.AuthenticationContextto encapsulate relevant context data.InitialConnectionHandlerto handle the authentication flow.Client side:
bmqimp_applicationto pass in anAuthenticationMessage.